[bugfix] Treat negative exit codes in PBS scheduler #3571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Colleen Bertoni <[email protected]>
|
Just to add some context, yes PBS use negative exit code... https://www.nas.nasa.gov/hecc/support/kb/pbs-exit-codes_185.html |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3571 +/- ##
========================================
Coverage 91.25% 91.25%
========================================
Files 62 62
Lines 13534 13534
========================================
Hits 12350 12350
Misses 1184 1184 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vkarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current regex used in the PBS scheduler can't capture negative exit codes.
See here. This PR fixes it. Coauthored by @colleeneb.